Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application-granular service registration and discovery are compatible with api calling methods #7369

Merged
merged 3 commits into from
May 31, 2021
Merged

Application-granular service registration and discovery are compatible with api calling methods #7369

merged 3 commits into from
May 31, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

Application-granular service registration and discovery are compatible with api calling methods.

see more detail from #7364

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@xiaoheng1
solve apache#7364 Application-granular service registration and disco…
a85a3f6 
…very are compatible with api calling methods
@codecov-io
Copy link

codecov-io commented Mar 14, 2021 •
edited
Loading

Codecov Report

Merging #7369 (62d9135) into master (e02be08) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7369      +/-   ##
============================================
+ Coverage     58.67%   58.70%   +0.02%     
+ Complexity      426      424       -2     
============================================
  Files          1044     1043       -1     
  Lines         42488    42475      -13     
  Branches       6231     6214      -17     
============================================
+ Hits          24930    24935       +5     
  Misses        14760    14760              
+ Partials       2798     2780      -18
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 70.00% <100.00%> (+0.30%) 0.00 <0.00> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 62.80% <100.00%> (+0.95%) 0.00 <0.00> (ø)
...in/java/org/apache/dubbo/common/utils/IOUtils.java 65.45% <0.00%> (-22.36%) 0.00% <0.00%> (ø%)
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0.00%> (-10.53%) 15.00% <0.00%> (-1.00%)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) 0.00% <0.00%> (ø%)
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) 8.00% <0.00%> (-1.00%)
...common/serialize/hessian2/Hessian2ObjectInput.java 92.00% <0.00%> (-3.46%) 0.00% <0.00%> (ø%)
...dubbo/remoting/exchange/support/DefaultFuture.java 85.47% <0.00%> (-2.57%) 0.00% <0.00%> (ø%)
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 94.59% <0.00%> (-2.47%) 0.00% <0.00%> (ø%)
...he/dubbo/common/threadpool/ThreadlessExecutor.java 94.23% <0.00%> (-1.93%) 0.00% <0.00%> (ø%)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02be08...62d9135. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 9a86bb7 into apache:master May 31, 2021
AlbumenJ added a commit that referenced this pull request May 31, 2021
@AlbumenJ
Revert "Application-granular service registration and discovery are c…
c42c231 
…ompatible with api calling methods (#7369)"

This reverts commit 9a86bb7.
@AlbumenJ AlbumenJ mentioned this pull request May 31, 2021
Closed
@icankeep icankeep mentioned this pull request Jun 2, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoheng1 @codecov-io @AlbumenJ